A better fetch with proper errors #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example of how things gracefully fail with meaningful errors (there it's a |
WebReflection
force-pushed
the
imporved-fetch
branch
from
6fdcab1 to
5164100
Compare
WebReflection
force-pushed
the
imporved-fetch
branch
from
5164100 to
1f0ce03
Compare
ntoll
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR supersedes #145 by actually improving the underlying library.
It's true that it doesn't reduce much bloat but while writing the other MR I've realized what a "burden" it would be to remember that when fetch fails we want to throw an error (or unhandled Promise rejection) so latest
@webreflection/fetchdoes that, it's 100% code covered, including errors and logs, so I believe it's better to just keep that updated instead of manually searching for all possible fetch in the wild./cc @ntoll ... thoughts?